Wrong parameters in left shift when calculation duration

tcunit / TcUnit

An unit testing framework for Beckhoff's TwinCAT 3

Other

258 stars 72 forks source link

Wrong parameters in left shift when calculation duration #227

Closed stefanbesler closed 9 months ago

stefanbesler commented 9 months ago

Every 429,4967296 seconds => 7.2 minutes the duration of the tests where calculated incorrectly due to a wrong left shift. To reproduce the bug without the PR:

start TcUnit-Verifier
put a breakpoint in TcUnit.F_GetCpuCounterAs64Bit
wait for CpuCounter.cpuCntLoDW to overflows from 4294967296 to 0 (32 bit variable)
remove the breakpoint
the duration is wrong

This PR closes #226 ... looking forward to the 1.3 release

sagatowski commented 9 months ago

@stefanbesler I just wanted to say that you are amazing! That was QUICK! I'm currently on travel but will be looking at this PR during the weekend.

Thank you so much! ❤️

sagatowski commented 9 months ago

Thank you @stefanbesler ❤️