search

tcunit / TcUnit

An unit testing framework for Beckhoff's TwinCAT 3
Other
273 stars 75 forks source link

feat: add os independent environment variable at parameter xUnitFilePath #239

Closed philippleidig closed 6 months ago

philippleidig commented 7 months ago

see #232

sagatowski commented 7 months ago

Looks great! Only one comment. Can you add an example of where it would point to on a Tc/BSD system? So in your example:

- %TC_BOOTPRJPATH% -> e.g. C:\TwinCAT\3.1\Boot\
- %TC_INSTALLPATH% -> e.g. C:\TwinCAT\3.1\

Could you change it to something like:

- %TC_BOOTPRJPATH% -> e.g. C:\TwinCAT\3.1\Boot\ (for Windows), /blabla/ (For Tc/BSD)
- %TC_INSTALLPATH% -> e.g. C:\TwinCAT\3.1\  (for Windows), /blabla/ (For Tc/BSD)

Have obviously no idea what the path on Tc/BSD is.

philippleidig commented 6 months ago

thanks for the hint 👍

sagatowski commented 6 months ago

This is great. Thanks @philippleidig.