Closed chali closed 1 week ago
Thanks for the PR!
I guess the question I have is:
Why wouldn't an exception in the producer bubble up to produce the very same error condition? Why is wrapping even necessary?
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.72%. Comparing base (
92fee05
) to head (f1b2754
). Report is 69 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The situation that is happening is if there is an Exception
in between tarOutputStream.putArchiveEntry(fileEntry);
and tarOutputStream.closeArchiveEntry();
like full temp space in the linked issue. It leaves tar entry in unclosed state. Then calling tarOutputStream.close()
that is in the finally
causes another exception. The first one is ignored and the second one is propagated outside. Leaving users without clue what actually happened.
Looking better! Thanks for the contribution!
Feel free to also include yourself as contributor https://github.com/tcurdt/jdeb/blob/master/pom.xml#L88 And this also still needs to be added to https://github.com/tcurdt/jdeb/blob/master/HISTORY.md
...and I just noticed a new release is overdue 🙃
Feel free to also include yourself as contributor https://github.com/tcurdt/jdeb/blob/master/pom.xml#L88 And this also still needs to be added to https://github.com/tcurdt/jdeb/blob/master/HISTORY.md
Working on those. https://github.com/tcurdt/jdeb/pull/708
...and I just noticed a new release is overdue 🙃
:-D little bit
We have just hit the same problem as #234 What do you think about following approach for those situations?