Repository managment - Githubissues

tcz / mink-phantomjs-driver

Work-in-progress Mink driver for PhantomJS

6 stars 6 forks source link

Repository managment #2

Open marekkalnik opened 11 years ago

marekkalnik commented 11 years ago

Hi,

How do we organize the repository management? The pull-requests, issues all of that? Will you do this or do you want me to do it in my repo?

tcz commented 11 years ago

Hi,

I understand your this is a temporary repo that's going to be discarded and transferred to a pull request in Mink. Isn't that so? If not, I can take care of this.

marekkalnik commented 11 years ago

You're completely right, but I guess we won't transfer it before it will be functional.

BTW, I'll have the process spawn and session setting implemented by the end of the week.

tcz commented 11 years ago

Cool! What do we need the process spawn for? I though the internal webserver in phantom is multipreocess already, is it not?

marekkalnik commented 11 years ago

It's just that we need to manage (boot and shutdown) the Phantom process when starting and ending the session. A bit like the zombiejs driver does:

https://github.com/Behat/MinkZombieDriver/blob/master/src/Behat/Mink/Driver/NodeJS/Server.php#L266

tcz commented 11 years ago

Ah sure, all right! I was thinking of something in the JS code.

I suggest the following structure for issues:

PHP code to start/stop server
PHP code to map driver interface functions to HTTP requests
small issues for each driver method to implement them in Phantom

What do you think?

marekkalnik commented 11 years ago

Seems right to me :+1:

tcz commented 11 years ago

I created the issues and added you as collaborator so that (I gues) you will be able to assign issues to yourself.

marekkalnik commented 11 years ago

Cool, thanks!