search

tczekajlo / kube-consul-register

a tool to register Kubernetes PODs as Consul Services
Apache License 2.0
105 stars 50 forks source link

Migrate from glide to dep #38

Closed arunvelsriram closed 5 years ago

arunvelsriram commented 5 years ago

Go community recommends dep instead of glide https://github.com/Masterminds/glide#golang-dep

To make sure I didn't break anything, I needed the tests and lint checks to pass before and after the dep migration. So this PR has become a dependent of my previous PR #37, where I fixed all the lint errors. One #37 is merged I will sync this PR with master branch and push again.

tczekajlo commented 5 years ago

@arunvelsriram Good job, thanks!

arunvelsriram commented 5 years ago

Does thevendor/ need to be checked-in to git? In the CI anyway, it's being removed and installed again so it already defeated the purpose I think.

https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory