search

tczekajlo / kube-consul-register

a tool to register Kubernetes PODs as Consul Services
Apache License 2.0
105 stars 50 forks source link

Skip adding Consul health check if exec liveness probe #44

Closed aswinkarthik closed 5 years ago

aswinkarthik commented 5 years ago

Fixes #32

Changes:

  1. Skip adding the Check for Consul if Exec type of livenessProbe
  2. Added tests

Note:

Currently skipping. It is possible for Consul to exec into a docker container and then run the command. It is also possible to get the container ID from the Kubernetes Pod Status. This could be an alternative approach instead of skipping