search

tczekajlo / kube-consul-register

a tool to register Kubernetes PODs as Consul Services
Apache License 2.0
105 stars 50 forks source link

Add readiness probe support for consul check #55

Closed rymdo closed 3 years ago

rymdo commented 3 years ago

PR adds the optional use of readiness probe for consul checks and the ability to enable/disable liveness/readiness probes via annotations. Useful when using the readiness probe for draining/terminating a pod with a non 200 status code, in our case responding with 429 to flag the pod with "warning" in consul.

webmutation commented 3 years ago

Hi, any idea when this will be merged? It would be very useful for our use case.

tczekajlo commented 3 years ago

@rymdo 👋🏻 Can you resolve conflicts? The PR looks good to me.

rymdo commented 3 years ago

@tczekajlo Should be fixed now 😁

tczekajlo commented 3 years ago

@rymdo Thanks a lot for your PR 🙏🏻

webmutation commented 3 years ago

Will you guys build a new docker image, the one on docker hub is pretty old. Thanks

tczekajlo commented 2 years ago

A new image is available here https://hub.docker.com/r/tczekajlo/kube-consul-register/tags