search

tdalon / ahk

Repository for AutoHotkey scripts including PowerTools
MIT License
83 stars 22 forks source link

Meeting Reactions not working with german Teams client #10

Closed Callidus2000 closed 1 year ago

Callidus2000 commented 2 years ago

Hi, is it possible to get Teamsy working with the german Teams Client?

tdalon commented 2 years ago

Hi and thanks for your interest in my repo :-) Teamsy and the whole repo were only implemented for an English language setting. (The one I use) It is possible to support other languages but requires some development effort. And till now you are the only one who has requested this.

Are you only talking about meeting reactions or in general? Please be precise in your request.

Some features like Meeting reactions are based on findtext/ imagesearch. Language shall not be an issue here. But anyway it might be necessary to take your screenshot with FindText to get it work for you.

Some features are based on the native hotkeys assigned in Teams. (not sure if hotkeys are lang. neutral) -

Some other Teamsy features are based on some Teams commands like /call: here I remember that the commands are definitely language specific.

If you are precise about what is not working for you and what would be the fix (e.g. list the commands in your language), I can have a look if I can implement this quickly. In general, you are free to edit the code to your specific needs. If it isn't something that I can do quickly and you would really like it, you might convince me to implement it for you by offering me some beer ;-)

itb-devs-de commented 1 year ago

This is an issue for me too. Almost none of the features are working because they rely on UI text instead of internal control names. For example the Mute/Unmute is broken because the Name is "Stummschalten" instead of "Mute".

Generally for UI automation it is better to not rely on UI text but on control names. For example the Mute button has the AutomationId "microphone-button", which can easily be targeted for all language clients equally.

image

tdalon commented 1 year ago

I have on my backlog to offer a setting to specific the client language used - but still you will have to implement your specific language on your own.

@itb-devs-de : I use the automation-id where it is possible. If I have hardcoded the Mute name this is for the feature to detect the mute state. Unfortunately the last time I have checked, the Teams client does not offer an automation-id for meeting reactions Therefore the implementation is language specific :-( I think I have even reported this to Microsoft but it is a bit hopeless here that MS improves the way the Teams client is implemented.

You are free to make any code improvement with a pull request if you know a better way to solve this issue.

tdalon commented 1 year ago

I have finally come to implement this for the German language (Mute and Meeting Reactions) as proof of concept how to implement. See https://tdalon.blogspot.com/2023/08/teams-powertools-lang-extension.html

tdalon commented 1 year ago

Improved language support see https://tdalon.blogspot.com/2023/10/teams-powertools-lang.html