does not compile with ghc-8.4

[0x777]

   /tmp/stack26892/ginger-0.7.3.0/src/Text/Ginger/Html.hs:24:15: error:
        • No instance for (Semigroup Html)
            arising from the 'deriving' clause of a data type declaration
          Possible fix:
            use a standalone 'deriving instance' declaration,
              so you can specify the instance context yourself
        • When deriving the instance for (Monoid Html)
       |
    24 |     deriving (Monoid, Show, Eq, Ord)
       |               ^^^^^^

I fixed this at https://github.com/hasura/ginger. I can submit a PR if needed.

[tdammers]

Please do. I could easily do it myself, but since you've already got a patch...

On Wed, Aug 29, 2018, 15:39 Vamshi Surabhi notifications@github.com wrote:

/tmp/stack26892/ginger-0.7.3.0/src/Text/Ginger/Html.hs:24:15: error: • No instance for (Semigroup Html) arising from the 'deriving' clause of a data type declaration Possible fix: use a standalone 'deriving instance' declaration, so you can specify the instance context yourself • When deriving the instance for (Monoid Html) | 24 | deriving (Monoid, Show, Eq, Ord) | ^^^^^^

I fixed this at https://github.com/hasura/ginger. I can submit a PR if needed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tdammers/ginger/issues/35, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXjx-8Flr5-IJw0iTqnkwtP6Ct91DqOks5uVpmCgaJpZM4WRkOC .

[tdammers]

Fixed in https://github.com/tdammers/ginger/pull/36.