search

tdammers / ginger

A Haskell implementation of the Jinja template language.
MIT License
77 stars 13 forks source link

fix compilation with ghc-8.4 #36

Closed 0x777 closed 6 years ago

0x777 commented 6 years ago

This PR only ensures compilation with ghc >= 8.0, we'll need to follow this if support for ghc < 8.0 is needed.

0x777 commented 6 years ago

Now, it should compile with ghc >= 7.8. Would you like an update to travis.yml to test against all ghc versions?

tdammers commented 6 years ago

Now, it should compile with ghc >= 7.8. Would you like an update to travis.yml to test against all ghc versions?

Sounds lovely. Probably best in a separate PR though.

tdammers commented 6 years ago

Why not just use --resolver?

On Thu, Aug 30, 2018, 04:21 Vamshi Surabhi notifications@github.com wrote:

@0x777 commented on this pull request.

In stack-ghc-7.10.3.yaml https://github.com/tdammers/ginger/pull/36#discussion_r213887219:

@@ -0,0 +1,32 @@ +# For more information, see: https://github.com/commercialhaskell/stack/blob/release/doc/yaml_configuration.md

The reason for these files is to test ginger against all ghc versions with commands:

stack build --fast --test --stack-yaml=stack-ghc-7.8.4.yaml stack build --fast --test --stack-yaml=stack-ghc-7.10.3.yaml stack build --fast --test --stack-yaml=stack-ghc-8.0.2.yaml stack build --fast --test --stack-yaml=stack-ghc-8.2.2.yaml stack build --fast

How do you prefer testing against different versions of ghc?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tdammers/ginger/pull/36#discussion_r213887219, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXjx4jpqqMyzKjO8aAx-zdVRzhdSXYxks5uV0wogaJpZM4WSLws .

tdammers commented 6 years ago

Thanks again for doing this.

BTW., if you like, add yourself to CONTRIBUTORS.md.