Saving game with CreateRegion in globals in Calendary system crashes the game

tdauth commented 1 month ago

Found it:

   private region rainyRegion = CreateRegion()

in calendar system.

CreateRegion in globals crashes the game on saving.

https://www.hiveworkshop.com/threads/list-of-warcraft-iii-crashes.194706/page-4#post-3637812

According to the user WchiWa it crashes since 3.23 and worked in 3.22. See all changes in 3.23: https://wowreforged.org/ChangeLog3.23.txt Calendar was not even there but LogUI and maybe FrameSaver stuff changed. Compare the map scripts war3map.j in git: https://github.com/tdauth/wowr/compare/3.22...3.23 34,009 wowr.w3x/war3map.j Copied! 20,244 additions, 13,765 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

It is not the FrameSaver action of the Log system.

It could be the new action bar, paged buttons, maybe even the syncing main selected units which is updated all the time. Check the FrameSaver actions.

    call FrameSaverAddEx(function GetMainSelectedUnitForPlayer_PauseSyncTimer , function GetMainSelectedUnitForPlayer_ResumeSyncTimer)

function WoWReforgedRacesUI__BeforeSave takes nothing returns nothing
    call h__PauseTimer(WoWReforgedRacesUI__updateTimer)
endfunction

function WoWReforgedRacesUI__AfterSave takes nothing returns nothing
    call h__ResumeTimer(WoWReforgedRacesUI__updateTimer)
endfunction

function WoWReforgedRacesUI__Init takes nothing returns nothing
    call h__TimerStart(WoWReforgedRacesUI__updateTimer, 0.3, true, function WoWReforgedRacesUI__TimerFunctionUpdateIdleWorkerIcons)

    // make sure that the timer will be paused and not run before restoring frames of GetIdleWorkerOverlayParent after loading the game

    call FrameSaverAddEx(function WoWReforgedRacesUI__BeforeSave , function WoWReforgedRacesUI__AfterSave)

endfunction

just pauses the timers

    //call FrameSaverAdd(function HideLogUI)
    //call FrameSaverAddEx(function DisableLogUI, function EnableLogUI)

Disabled for now.

function WoWReforgedSkillUI__AboutToSave takes nothing returns nothing
    call DisableSkillUITriggers()
    call WoWReforgedSkillUI__HideSkillUI()
endfunction

function WoWReforgedSkillUI__AfterSaving takes nothing returns nothing
    call EnableSkillUITriggers()
    call UpdateSkillPointsUIForAllPlayers()
endfunction

function WoWReforgedSkillUI__Init takes nothing returns nothing
    call TriggerRegisterAnyUnitEventBJ(WoWReforgedSkillUI__selectionTrigger, EVENT_PLAYER_UNIT_SELECTED)
    call TriggerAddCondition(WoWReforgedSkillUI__selectionTrigger, Condition(function WoWReforgedSkillUI__TriggerConditionSelected))

    call TriggerRegisterAnyUnitEventBJ(WoWReforgedSkillUI__deselectionTrigger, EVENT_PLAYER_UNIT_DESELECTED)
    call TriggerAddCondition(WoWReforgedSkillUI__deselectionTrigger, Condition(function WoWReforgedSkillUI__TriggerConditionDeselected))

    call TriggerRegisterAnyUnitEventBJ(WoWReforgedSkillUI__loadTrigger, EVENT_PLAYER_UNIT_LOADED)
    call TriggerAddCondition(WoWReforgedSkillUI__loadTrigger, Condition(function WoWReforgedSkillUI__TriggerConditioLoaded))

    // leveling is done by UpdateSkillUIEvaluate

    call DisableSkillUITriggers()

    call TriggerAddAction(WoWReforgedSkillUI__tmpTrigger, function WoWReforgedSkillUI__TriggerActionUpdateSkillPointsUI)

    // Makes sure no events are triggered before the UI is restored after loading the game.
    call TriggerAddAction(FrameLoader___actionTrigger, (function CreateAndEnableSkillUI)) // INLINED!!
    call FrameSaverAddEx(function WoWReforgedSkillUI__AboutToSave , function WoWReforgedSkillUI__AfterSaving)

hides.

function s__MapChanger_triggerConditionSaveUser takes nothing returns boolean
        return IsInSinglePlayer()
    endfunction

    function s__MapChanger_triggerActionSaveUser takes nothing returns nothing
        local string levelName= null
        local string zoneSaveGame= null
        local string zoneTargetSaveGame= null
        local integer i= 0
        // Remove existing zones directory if a savegame already existed with the same name, otherwise old zone save games will remain.
        call RemoveSaveDirectory(s__MapChanger_saveGameFolder(GetSaveBasicFilename()))
        // Copy savegames for all zones into the new directory. Consider that every map needs ALL zones therefore. Disable unused zones in the map.
        loop
            exitwhen ( i == (WoWReforgedLevels___levelCounter) ) // INLINED!!
            set levelName=(WoWReforgedLevels___levelName[(i)]) // INLINED!!
            set zoneSaveGame=(s__MapChanger_saveGamePath("" , (levelName))) // INLINED!!
            if ( (s__MapChanger_getZoneNameIndex((levelName)) != - 1) and SaveGameExists(zoneSaveGame) ) then // INLINED!!
                set zoneTargetSaveGame=s__MapChanger_saveGamePath(GetSaveBasicFilename() , levelName)
                call CopySaveGame(zoneSaveGame, zoneTargetSaveGame)
            endif
            set i=i + 1
        endloop

        set s__MapChanger_m_currentSaveGame=GetSaveBasicFilename()
    endfunction

Map Change does all this shit when in single player.

tdauth commented 1 month ago

It is not //call FrameSaverAddEx(function AboutToSave, function AfterSaving) of SKillUI.

tdauth commented 1 month ago

It is not the MapChanger.

tdauth commented 1 month ago

 call TriggerAddAction(FrameSaver___saveTrigger, (function HideUrlUi)) // INLINED!!
   call TriggerAddAction(FrameSaver___saveTrigger, (function HideAiPlayersUi)) // INLINED!!
    call TriggerAddAction(FrameSaver___saveTrigger, (function HidePagedButtonsUI)) // INLINED!!
    call TriggerAddAction(FrameSaver___saveTrigger, (function UnitSoundSetsFakeBars___PauseAllFrameTimers)) // INLINED!!
    call TriggerAddAction(FrameSaver___saveTrigger, (function HideCinematicSceneFakeBars)) // INLINED!!
   call TriggerAddAction(FrameSaver___saveTrigger, (function HideBackpackUIForAllPlayers)) // INLINED!!
    call TriggerAddAction(FrameSaver___saveTrigger, (function HideSaveCodeUIAll)) // INLINED!!

tdauth commented 1 month ago

Not HideUrlUi

tdauth commented 1 month ago

Not HideAiPlayersUi

tdauth commented 1 month ago

Not HidePagedButtonsUI

tdauth commented 1 month ago

Not the custom sound sets:

    call TriggerAddAction(FrameSaver___saveTrigger, (function UnitSoundSetsFakeBars___PauseAllFrameTimers)) // INLINED!!
    call TriggerAddAction(FrameSaver___saveTrigger, (function HideCinematicSceneFakeBars)) // INLINED!!

tdauth commented 1 month ago

Not //call FrameSaverAdd(function HideBackpackUIForAllPlayers)

tdauth commented 1 month ago

Not //call FrameSaverAdd(function HideSaveCodeUIAll)

tdauth commented 1 month ago

Not //call FrameSaverAddEx(function BeforeSave, function AfterSave) for races UI

tdauth commented 1 month ago

Nothing with EVENT_GAME_SAVE.

tdauth commented 1 month ago

I suspect that same frame saver functionality is missing. Maybe something should be disabled, some timer updating UI which is called immediately after saving and accesses corrupted UI.

tdauth commented 1 month ago

Make sure that the trigger with the MAP_SAVE is really disabled.

tdauth commented 3 weeks ago

Actually, the line

call TriggerAddAction(FrameSaver___saveTrigger, (function HideCinematicSceneFakeBars)) // INLINED!!

was new in 3.23 where it crashed make sure it is not the cause.

Besides this is new:

framehandle PagedButtonsUI___PreviewSprite= null
effect PagedButtonsUI___PreviewEffect= null
call TriggerAddAction(FrameSaver___saveTrigger, (function PagedButtonsUI___ResetPreviewFrame)) // Destroying the frame will crash the game. // INLINED!!

tdauth commented 3 weeks ago

Also the buttons in the actions bar are new:

framehandle WoWReforgedActionsBarUI__LogButton
framehandle WoWReforgedActionsBarUI__LogFrame
framehandle WoWReforgedActionsBarUI__LogTooltip
trigger WoWReforgedActionsBarUI__LogTrigger

framehandle WoWReforgedActionsBarUI__MultiboardButton
framehandle WoWReforgedActionsBarUI__MultiboardFrame
framehandle WoWReforgedActionsBarUI__MultiboardTooltip
trigger WoWReforgedActionsBarUI__MultiboardTrigger

integer WoWReforgedActionsBarUI__currentMultiboard= 0