search

tdaverse / ggtda

ggplot2 extension to visualize persistent homology
https://tdaverse.github.io/ggtda/
GNU General Public License v3.0
20 stars 5 forks source link

Params #11

Closed corybrunson closed 4 years ago

corybrunson commented 4 years ago

Sorry, forgot to PR yesterday! These should be merged into master if acceptable so that they're in the first CRAN release. Ideally, we will only very rarely change the API after first submission.

corybrunson commented 4 years ago

@rrrlw i'm not committed to flat or diagonal; they both have their theoretical advantages, so maybe it should come down to common use.

rrrlw commented 4 years ago

Sounds like we reached a consensus on diagonal on Slack; cool if I switch default and merge this PR?

corybrunson commented 4 years ago

@rrrlw that's cool with me. : )