search

tdaverse / ggtda

ggplot2 extension to visualize persistent homology
https://tdaverse.github.io/ggtda/
GNU General Public License v3.0
20 stars 5 forks source link

add NEWS and cran-comments for CRAN submission #12

Closed rrrlw closed 4 years ago

rrrlw commented 4 years ago

Looks like this could go into master as well prior to CRAN submission? R CMD check on my local Windows machine (R 4.0.0) ran w/o issues, updated cran-comments.md accordingly

corybrunson commented 4 years ago

Oh, sorry for not documenting this branch. My current workflow is to merge master into this branch after submission, so that the branch agrees with the current version available from CRAN—but it looks like that's not the case here. So, sure, let's merge this in and then drop the cran branch unless we feel we need it.

rrrlw commented 4 years ago

I don't want to mess w/ your workflow - happy to leave cran branch as-is! Once ggtda is on CRAN, will be quite nice to have this here