search

tdaverse / ggtda

ggplot2 extension to visualize persistent homology
https://tdaverse.github.io/ggtda/
GNU General Public License v3.0
21 stars 6 forks source link

doc(readme): distinguish diagonal line and cutoff line in persistence diagram #30

Closed corybrunson closed 4 years ago

corybrunson commented 4 years ago

NOTE: The original cutoff line may have been wrongly parameterized and later reparameterized as the common line y=x used as a visual cue. The visual cue is now dark gray and the goldenrod cutoff line is corrected.

I just noticed this and wanted to be sure to correct it before the CRAN submission!

rrrlw commented 4 years ago

This was my mistake! I thought the initial dashed line was the diagonal reference line usually seen in persistence diagrams and needed to be corrected after we switched the default for stat_persistence from flat to diagonal.