search

tdaverse / ggtda

ggplot2 extension to visualize persistent homology
https://tdaverse.github.io/ggtda/
GNU General Public License v3.0
21 stars 6 forks source link

missing aesthetics documentation #38

Closed rrrlw closed 9 months ago

rrrlw commented 3 years ago

see convo in #21

corybrunson commented 3 years ago

This might technically be a separate issue, but it's so closely related that i think it belongs here. As i explained to myself here, documentation is especially important for computed variables used for calculated aesthetics. ggtda includes one computed variable, persistence, computed by stat_persistence(). Could we include a section for it in this stat's documentation? (Note: It's already used in one example, which is good.)

corybrunson commented 10 months ago

This is addressed in 68854ac328f9268c1481591cbc3c327630523cbb and can be closed once that commit is merged to main.