search

tdaverse / ggtda

ggplot2 extension to visualize persistent homology
https://tdaverse.github.io/ggtda/
GNU General Public License v3.0
20 stars 5 forks source link

fix(diagonal): require unique aesthetic vaules only within panel #41

Closed corybrunson closed 2 years ago

corybrunson commented 2 years ago

I tried faceting some persistence diagrams and found that the diagonal geom failed to account for the internal PANEL variable used for this purpose. This fix works for my examples (and reduces the dependency on dplyr), but @rrrlw i wanted to run it by you in case you have some other examples using the diagonal geom that would be worth checking. Thanks!

corybrunson commented 2 years ago

@rrrlw without objection, i'll merge this PR this weekend!