search

tdaverse / ggtda

ggplot2 extension to visualize persistent homology
https://tdaverse.github.io/ggtda/
GNU General Public License v3.0
21 stars 6 forks source link

make complex parameter case-insensitive #47

Closed corybrunson closed 10 months ago

corybrunson commented 11 months ago

Note: This issue refers to the underway merge of the StatSimplicialComplex and main branches.

I think the simplicial_complex layer should accept any-case spellings of "Cech", "alpha", etc. This can be done using tolower().

I raise it as an issue rather than unilaterally making the change because i don't know whether it makes more sense to apply tolower() in the internal helper function assign_complex_engine or in the ggproto function StatSimplicialComplex$setup_data(). I'd welcome advice.

corybrunson commented 10 months ago

On second thought (and some searching), this seems to be uncommon in the Tidyverse, so i'll close it as not planned.