search

tdaverse / ggtda

ggplot2 extension to visualize persistent homology
https://tdaverse.github.io/ggtda/
GNU General Public License v3.0
21 stars 6 forks source link

prevent inconsistency in diagram type across layers #51

Open corybrunson opened 10 months ago

corybrunson commented 10 months ago

A major problem with the diagram parameter is that different values can be applied to different layers, which results in nonsense. Instead, new coordinate system ggproto classes should be used, perhaps CoordFlat and CoordLandscape, which would transform the entire plot.

corybrunson commented 10 months ago

This turned out to be a naïve idea! The different diagrams belong to the statistical transformation; a coordinate ggproto would totally reformat the plot.

The problem of consistency in the use of diagram remains, which might be resolved by making it a settable option.