Establish M2.4 compatibility - Githubissues

tddwizard / magento2-fixtures

Fixture library for Magento 2 integration tests by @schmengler (@integer-net)

http://tddwizard.com/

MIT License

142 stars 28 forks source link

Establish M2.4 compatibility #48

Closed mam08ixo closed 4 years ago

mam08ixo commented 4 years ago

This PR establishes compatibility with Magento 2.4 and drops compatibility with the now EOL'd Magento 2.2 (see also #38).

The main changes are:

PHP version requirement updated
Module version dependencies updated
Return type declarations (setUp, tearDown) aligned with PHPUnit 9 base methods
Test assertions refactored to low-level checks where there is no common candidate in PHPUnit 6 (M2.3) and PHPUnit 9 (M2.4)

I also took care of some inspection issues while I was there.

schmengler commented 4 years ago

Looking good!