tddwizard / magento2-fixtures

Fixture library for Magento 2 integration tests by @schmengler (@integer-net)

http://tddwizard.com/

MIT License

141 stars 28 forks source link

Adding possibility to create company address #50

Closed bartoszkubicki closed 4 years ago

bartoszkubicki commented 4 years ago

45

schmengler commented 4 years ago

Looks good so far! Would you mind adding a test case to the CustomerBuilderTest ?

bartoszkubicki commented 4 years ago

Sure, I will try to write it until next weekend

bartoszkubicki commented 4 years ago

@schmengler I had difficulties with running tests because of not existing reference in tests/phpunit.xml.dist:10. I had to test code in some existing magento project. Case seems to be really similar testLocalizedAddresses() so I think it should work. Are test run during these checks here?

schmengler commented 4 years ago

@bartoszkubicki yes, it needs to be tested within Magento and tests are run here with Travis CI, but for some reason Travis is not linked in the checks. After the merge conflict is resolved, we'll see if it passes

schmengler commented 4 years ago

Solving the conflict via the Github UI had a very weird effect on the build, I'm going to merge your PR as it is looking good to me, and if tests are failing, we'll solve it with a new PR

Thank you!

schmengler commented 4 years ago

OK, there are incompatibilities with my latest refactorings, but I'll solve them

=> #57

bartoszkubicki commented 4 years ago

Solving the conflict via the Github UI had a very weird effect on the build, I'm going to merge your PR as it is looking good to me, and if tests are failing, we'll solve it with a new PR

Thank you!

Oh yes, in gitlab its the same