search

tddwizard / magento2-fixtures

Fixture library for Magento 2 integration tests by @schmengler (@integer-net)
http://tddwizard.com/
MIT License
142 stars 28 forks source link

Add builder for product attributes that have options #63

Closed lfolco closed 3 years ago

lfolco commented 3 years ago

I've been running into an issue where I need to test product attributes that use options (not from a custom database source model). This PR adds the ability to add options to the database for a given attribute.

lfolco commented 3 years ago

I'm getting a CodeClimate failure on the use of an else expression, never encountered that, and I pulled my code from an existing class.

schmengler commented 3 years ago

Great! Nevermind the CodeClimate issue, I've set it to "wontfix" now. Removing else will not make this code simpler IMHO