search

tddwizard / magento2-fixtures

Fixture library for Magento 2 integration tests by @schmengler (@integer-net)
http://tddwizard.com/
MIT License
141 stars 28 forks source link

add build without save method for products #64

Closed lfolco closed 3 years ago

lfolco commented 3 years ago

This adds the ability to create a product without saving it. I tend to use this quite a bit in my own tests and I usually override the ProductBuilder in order to do that.

schmengler commented 3 years ago

Nice addition, thank you!

schmengler commented 3 years ago

Unfortunately this breaks on Magento 2.3 because its old PhpUnit version does not support assertMatchesRegularExpression. While the 2.3 branch is still supported I would like to stay compatible

lfolco commented 3 years ago

Ah! That test was failing in my setup. I'll revert it back.

On Jan 11, 2021, at 1:54 PM, schmengler notifications@github.com wrote:

Unfortunately this breaks on Magento 2.3 because its old PhpUnit version does not support assertMatchesRegularExpression. While the 2.3 branch is still supported I would like to stay compatible

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tddwizard/magento2-fixtures/pull/64#issuecomment-758152394, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANBKEJGV2WEPLS3MZQNQETSZNCNFANCNFSM4V55ATRA.

lfolco commented 3 years ago

Changes reverted, although I'm still failing on CodeClimate (not sure what to do about that)

schmengler commented 3 years ago

That looks like a false positive, all good :ok_hand: