search

tdebatty / java-LSH

A Java implementation of Locality Sensitive Hashing (LSH)
Other
295 stars 84 forks source link

avoid java serialization #10

Closed kireet closed 8 years ago

kireet commented 8 years ago

java serialization can be quite tricky to get right, especially as code changes over time. It would be nice if client code had the option of passing a seed value to the LSH classes that would be passed through to Random objects created during initialization and thus allowing for consistent hashes across object instantiations without having to deal with serialization at all.

tdebatty commented 8 years ago

Hi, Sorry for the late answer... I really like your idea. I'm gonna give it a try this week! Best regards,

kireet commented 8 years ago

i took a shot at this and created a pull request in issue #11

sorry, i am not that familiar with github so i didn't know how to attach it to this issue...

tdebatty commented 8 years ago

Hi, I merged you pull request I made some style modifications to be consistent with the rest of the code and I made a new release (should be available on maven within a few hours) I will also modify the examples to mention this possibility Best regards,