tdeboissiere / DeepLearningImplementations

Implementation of recent Deep Learning papers
MIT License
1.81k stars 652 forks source link

Update parmap API to remove DeprecationWarnings #54

Closed zeehio closed 6 years ago

zeehio commented 6 years ago

Hi,

parmap 1.5.0 introduced support for passing keyword arguments to mapped functions. The drawback of this feature is that a consistent naming of parmap arguments is needed in order to prevent conflicts between parmap arguments and user-defined arguments. The new parmap convention is to prefix all its arguments with "pm_" (for parmap) as documented http://parmap.readthedocs.io/en/latest/

This commit updates the DeepLearningImplementations parmap calls to use the new API, removing the deprecation warnings that appear with parmap==1.5.1 (the parmap version used).

https://github.com/zeehio/parmap/blob/e0bc5969ab13562ec9ea2d8131f1cd9ecb8448a7/ChangeLog#L11

Feel free to merge if you see fit :+1:

Sergio (parmap author)

tdeboissiere commented 6 years ago

Sounds good, merging