Hi Thomas,
This branch includes several small changes to get the model running with more recent versions of Python and some packages:
print statements are replaced with print functions (e.g. print "hello" must be print("hello") in Python 3.x)
xrange is replaced with range
iterkeys() is replaced with keys()
the window input to .rolling() must be an integer
I also found two small instances where plotting functions used a static copy of bs rather than the one they were passed, and I added handling for one nan instance in calcFuelPrices().
I wrote a small test file to check/demonstrate that it runs with the changes - would you like me to add that to this PR? To anyone else reading this: it is available on my forked version of the repo.
Thank you for making this model available and for commenting it so thoroughly.
Best,
Siobhan
Hi Thomas, This branch includes several small changes to get the model running with more recent versions of Python and some packages:
print "hello"
must beprint("hello")
in Python 3.x)xrange
is replaced withrange
iterkeys()
is replaced withkeys()
.rolling()
must be an integerI also found two small instances where plotting functions used a static copy of
bs
rather than the one they were passed, and I added handling for onenan
instance incalcFuelPrices()
.I wrote a small test file to check/demonstrate that it runs with the changes - would you like me to add that to this PR? To anyone else reading this: it is available on my forked version of the repo.
Thank you for making this model available and for commenting it so thoroughly. Best, Siobhan