search

tdegrunt / jsonschema

JSON Schema validation
Other
1.82k stars 262 forks source link

Use web URL API instead of Node URL library #396

Closed henryrgithub closed 5 months ago

henryrgithub commented 5 months ago

Addresses #395, #393, #367, and #20. Motivated generally by wanting to frictionlessly use jsonschema while prototyping with Vite.

2764 tests passed, 9 pending, same as before changes.

I am looking at making a resolve helper method instead of duplicating logic everywhere, but I need to educate myself on JS scoping stuff before making it work.

I also changed the test suite submodule URL to https from git, I think submodule init for it will work whether or not you SSH'd or HTTPS'd the repo. I'll happily revert if that's more appropriate for a seperate PR or git syntax is preffered.

henryrgithub commented 5 months ago

Refactored to use a helper function instead of duplicated code.

tdegrunt commented 5 months ago

Nice, that solves quite a few problems in one go! Thank you!

Sinled commented 4 months ago

Was this fix released? It seems no newer versions on npm.

wubaibai commented 1 month ago

Hi, @tdegrunt, May I know when will this fix to be released to npm?