search

tdelmas / website

Let's Encrypt Website and Documentation
https://letsencrypt.org
Mozilla Public License 2.0
2 stars 3 forks source link

PayPal: Remove unnecessary paypalCountry #23

Closed labanskoller closed 4 years ago

labanskoller commented 4 years ago

The new variable paypalCountry is not needed. Let's use the part after the dash in the languageCode instead. Add a country to the few languageCodes not having it and where it's not the same as the language part.

Even if a languageCode is set to only "de" it will still work given it's the code for both the country and the language.

labanskoller commented 4 years ago

I think this will work together with https://github.com/letsencrypt/website/pull/804 since the country is still the last part of languageCode even for e.g. "zh-Hant-TW".

tdelmas commented 4 years ago

It's a clever way to do it, but I think it's better to keep the explicit "paypalCountry", and avoid to link these two distinct concepts (the country for PayPal and the country of the locale).

It also allows to set it to "US" if needed (for example to avoid the odd interface with id, ja, ko, ru and cn)

labanskoller commented 4 years ago

I see. Yeah I think we might need to do some exceptions. I'll close this PR.

tdelmas commented 4 years ago

The exceptions have been committed in https://github.com/letsencrypt/website/pull/809/commits/0a5ae3db4453e1a161cf45a55f36326f97139b36