Return with the exit status of a run file.

tdenniston / bish

Bish is a language that compiles to Bash. It's designed to give shell scripting a more comfortable and modern feel.

MIT License

1.48k stars 36 forks source link

Return with the exit status of a run file. #40

Closed noahmorrison closed 9 years ago

noahmorrison commented 9 years ago

When a file is run with ./bish -r file.bish it returns with the exit status of file.bish. Closes #39

tdenniston commented 9 years ago

Great! This was bugging me, as it prevents the "run all tests" script from failing if an individual test fails.

Can you do two small things:

Add a small comment explaining why you divide by 256
Collapse exit_status lines into a single line: int exit_status = run_on_bash(s);

noahmorrison commented 9 years ago

Sorry about taking so long to respond, I pushed that pull request right as I left to see my grandmother.

I defined the variable on a different line because of KNF (style(9), whatever you want to call it). Which style guide do you use? I'd like to follow it in future commits to this project, just don't know which one you're using

tdenniston commented 9 years ago

No worries :-).

The closest style is Google's C++ style guide: https://google-styleguide.googlecode.com/svn/trunk/cppguide.html just with some minor differences (4 versus 2 space indent, constants are all caps, no difference in function naming convention for accessors, etc).

noahmorrison commented 9 years ago

Thanks! I'll look into that style guide On Mar 18, 2015 7:32 AM, "Tyler Denniston" notifications@github.com wrote:

No worries :-).

The closest style is Google's C++ style guide: https://google-styleguide.googlecode.com/svn/trunk/cppguide.html just with some minor differences (4 versus 2 space indent, constants are all caps, no difference in function naming convention for accessors, etc).

— Reply to this email directly or view it on GitHub https://github.com/tdenniston/bish/pull/40#issuecomment-82916893.