Make it able to generate library-only bash scripts

tdenniston / bish

Bish is a language that compiles to Bash. It's designed to give shell scripting a more comfortable and modern feel.

MIT License

1.48k stars 36 forks source link

Make it able to generate library-only bash scripts #49

Open Icenowy opened 9 years ago

Icenowy commented 9 years ago

Only ignored things about "main"... It's provided by a parameter "-l". If you don't care, I may port autobuild3(https://github.com/AOSC-Dev/autobuild3)'s plug-able library architecture to bish.

tdenniston commented 9 years ago

This is a good idea. Can you make the following changes before I merge:

Instead of passing compile_as_library to the code generator, pass it to Parser::parse() instead. Then in Parser::module(), if compile_as_library is true, do not insert the main function at all. The code generator will then check if a main function is defined before inserting a call to it.
Fix up some whitespace inconsistencies. In particular, things like if(!compile_as_library) { should have a space between if and (.

Icenowy commented 9 years ago

Yet, I'll fit the coding style... But I tried to prevent it from creating 'main', and failed...Then I stashed the code

tdenniston commented 9 years ago

@Icenowy If you let me know what was failing, I can help you get it fixed.

Icenowy commented 9 years ago

I tried to disable the code of global var generating, main generating and allowed the main function pointer to be NULL

tdenniston commented 9 years ago

Yes, I think that's the best way to do it. Let me know if you have problems implementing it.

Artoria2e5 commented 9 years ago

Pulled from upstream.

Re-assigned the compile-as-library feature to command line flag -L.
Added rule test to Makefile. Added -Wall flag.

NEW DEFECT It seems that abort() causes segfaults in cygwin when I tried to open an inexist file.

Uh-oh I misspelled conflict.