search

tdenniston / bish

Bish is a language that compiles to Bash. It's designed to give shell scripting a more comfortable and modern feel.
MIT License
1.48k stars 36 forks source link

Exit with 0 when executing with -h argument #65

Closed heyvito closed 9 years ago

heyvito commented 9 years ago

Should bish -h really exit with code 1? I mean, I asked for the usage information, it printed it out, so we have a success, right? This also allows me to successfully test the brew formulae. :grinning:

heyvito commented 9 years ago

Hey @tdenniston, can you release this as an 0.1.1 tag? Brew require a test and I cannot make it pass with bish exiting with code 1. :disappointed_relieved:

tdenniston commented 9 years ago

@victorgama Sure, no problem. Will there be any other changes needed for the brew package to work? If so, it might be nice to get those in before doing a 0.1.1 tag. In particular I'm wondering if you needed any Makefile changes to install stdlib.bish somewhere.

heyvito commented 9 years ago

I could successfully compile and install through Brew. The only problem is to provide the test I mentioned. I guess this is required by the Homebrew staff before they accept the formulae.

I will make a 0.1.1 release on my fork and test using it before confirming, but I think this is the only change I need.

Will confirm ASAP.

Sent from my iPhone

On Apr 20, 2015, at 6:41 PM, Tyler Denniston notifications@github.com wrote:

@victorgama Sure, no problem. Will there be any other changes needed for the brew package to work? If so, it might be nice to get those in before doing a 0.1.1 tag. In particular I'm wondering if you needed any Makefile changes to install stdlib.bish somewhere.

— Reply to this email directly or view it on GitHub.

heyvito commented 9 years ago

Oh, just noticed the stdlib.bish part. Will also confirm this as soon as possible. If I run into any problem, where should I place this file? Is there any default path bish looks into?

tdenniston commented 9 years ago

I think probably the install and uninstall Makefile targets will need to be modified to copy stdlib.bish to a library directory. The path to find stdlib.bish is set at compile time with the CONFIG_CONSTANTS variable in the Makefile, so that should also probably be updated to point to the correct path. Happy to help if you have trouble figuring it out.

heyvito commented 9 years ago

@tdenniston Good news: I was able to write the test command by compiling and checking the output of a simple bish script, so you can hold the -h change to the next planned release. :grinning:

I will be opening a pull request to brew in the next few minutes and can open another PR here to update your README.

I just would like to know if you can ping me whenever you make a new release, so I can update the formulae. Even watching this repo, GitHub did not send me an email.

Edit: Oh, and I could successfully handle the stdlib.bish problem. Thank you!

heyvito commented 9 years ago

Brew pull request: homebrew/homebrew#38896

heyvito commented 9 years ago

@tdenniston Just a follow up: Homebrew rejected bish due to its early-development state, but I think they will accept it in a devel-only repository, which also allows bish to be installed through brew. (:

tdenniston commented 9 years ago

@victorgama Great! Thanks for setting that up. I think a development only repository is a good place for bish until it matures a bit more.

heyvito commented 9 years ago

I do agree. I thought the mainstream repository would also be a good place, given how useful bish is. :)

--  Victor Gama http://vito.io +55 11 953 804 895

On April 22, 2015 at 3:36:18 PM, Tyler Denniston (notifications@github.com) wrote:

@victorgama Great! Thanks for setting that up. I think a development only repository is a good place for bish until it matures a bit more.

— Reply to this email directly or view it on GitHub.

tdenniston commented 9 years ago

Hehe, thanks :-).