search

tdex-network / tdex-analytics

Analytics and Historical data feed about TDEX Network
MIT License
0 stars 6 forks source link

Fix conversion of market price in reference currency #36

Closed altafan closed 2 years ago

altafan commented 2 years ago

This fixes the conversion of markets' prices to reference currency for those containing a stable coin as base or quote asset.

Closes #24 Closes #32

Please @tiero @sekulicd review this.

altafan commented 2 years ago

@sekulicd I didn't touch anything about market balance but for some reason some of the tests are failing.

And also tests about MarketsPrice are failing even if i didn't change the fixtures. Can you help me figuring this out in order to make the CI pass?

altafan commented 2 years ago

@tiero Done! I had to fix also the rater service imp and more importantly its tests. There, there are a lot of tests for exported and unexported functions, but unfortunately, there were some mistakes.

I'll eventually check and fix all remaining tests in a later PR.

sekulicd commented 2 years ago

@sekulicd I didn't touch anything about market balance but for some reason some of the tests are failing.

And also tests about MarketsPrice are failing even if i didn't change the fixtures. Can you help me figuring this out in order to make the CI pass?

Fixed with latest commit. @tiero @altafan Rest LGTM.