[GetInfo] Return daemon fixed assets

tdex-network / tdex-daemon

Go implementation of the TDEX Beta Daemon

https://tdex.network

MIT License

11 stars 13 forks source link

[GetInfo] Return daemon fixed assets #565

Closed Janaka-Steph closed 2 years ago

Janaka-Steph commented 2 years ago

Environment variables TDEX_BASE_ASSET fixes the base asset, TDEX_QUOTE_ASSET fixes the quote asset. Return this info in GetInfo so that clients can display this information to the operator.

tiero commented 2 years ago

What about returning the full configuarion (ie. viper ENV VAR) in GetInfo or a new GetConfig RPC? @sekulicd @altafan

altafan commented 2 years ago

GetConfig would return info out of the scope of its service (WalletService) considering that the full configuration includes things like the datadir, TLS/macaroons location, the profiler stats interval, and so on. I'm not even sure what's the advantage for the operator to retrieve the configs via rpc.

Rather, I do think it could be useful for him to know what's the daemon's fixed asset, as @Janaka-Steph proposed.