tdex-network / tdex-daemon

Go implementation of the TDEX Beta Daemon
https://tdex.network
MIT License
11 stars 13 forks source link

GetInfoResponse.buildData not correct #592

Closed Janaka-Steph closed 2 years ago

Janaka-Steph commented 2 years ago

On regtest and testnet GetInfoResponse.buildData is always:

{
    "version": "dev",
    "commit": "none",
    "date": "unknown"
}

In particular, I am expecting version to be a semver.

Not tested with a mainnet daemon because they all require to be updated in order to work with latest grpc interface.

tiero commented 2 years ago

This should work when build from github releases, not locally

Janaka-Steph commented 2 years ago

This should work when build from github releases, not locally

Can testnet daemons be built from github releases ?

tiero commented 2 years ago

they should be. Is the docker container you pull giving same response? if yes, then yeah something wrong when we build the machine

tiero commented 2 years ago

Can confirm, with latest docker image tagged, version/commit etc.. is not injected apparently

Run container

docker run -d -it --network nigiri --name tdexd -p 9945:9945 -p 9000:9000 -e TDEX_NETWORK=regtest -e TDEX_BASE_ASSET=5ac9f65c0efcc4775e0baec4ec03abdde22473cd3cf33c0419ca290e0751b225 -e TDEX_EXPLORER_ENDPOINT=http://chopsticks-liquid:3000 -e TDEX_LOG_LEVEL=5  -v `pwd`/tdexd:/.tdex-daemon ghcr.io/tdex-network/tdexd:latest
59a0347677c347b259c507c9cab76454cc61053213d2229b4d52a6f746a987d5

Init

docker exec tdexd tdex init --password="ciaociao" --seed="aim fun issue fit diamond diamond boring cargo wrong flag reason taxi enrich faith fetch staff border mosquito arrive predict gloom flock logic rebel"
create wallet STATUS_PROCESSING
create wallet STATUS_DONE
admin.macaroon 0201057464657864028b01030a1010a0dd82ec316985071c9bc6ab0f0da01201301a150a066d61726b6574120472656164120577726974651a170a086f70657261746f72120472656164120577726974651a140a057072696365120472656164120577726974651a150a0677616c6c6574120472656164120577726974651a160a07776562686f6f6b12047265616412057772697465000006203881b2a5db33113cd95617a537f9c062be52425960774abccf780066cdb60b0e

Wallet is initialized. You can unlock
docker exec tdexd tdex unlock --password ciaociao

Wallet is unlocked
docker exec tdexd tdex info
{
    "root_path": "m/84'/0'",
    "master_blinding_key": "287227fc066e33ec2f3b0da765f85c94fab62ec18daff2ef1f9a22938010eee9",
    "account_info": [
    ],
    "network": "regtest",
    "build_data": {
        "version": "dev",
        "commit": "none",
        "date": "unknown"
    },
    "fixed_base_asset": "5ac9f65c0efcc4775e0baec4ec03abdde22473cd3cf33c0419ca290e0751b225",
    "fixed_quote_asset": ""
}