search

tdex-network / tdex-daemon

Go implementation of the TDEX Beta Daemon
https://tdex.network
MIT License
11 stars 13 forks source link

Drop OperatorService.GetMarketBalance? #601

Closed altafan closed 1 year ago

altafan commented 2 years ago

In operator.proto we have 2 methods that look a bit redundant: GetMarketBalance is basically a subset of GetMarketInfo. Could be worth dropping GetMarketBalance?

tiero commented 2 years ago

Looks good to me, nor priority tho

Please share your thoughts @sekulicd

sekulicd commented 2 years ago

ACK

altafan commented 2 years ago

@sekulicd can you make sure of the impact of this for tdex-dashboard?

sekulicd commented 2 years ago

Its true that GetMarketBalance is subset of GetMarketInfo, note that GetMarketInfo returns only unlocked balance while GetMarketBalance returns both locked and unlocked.

Removing GetMarketBalance would mean we need to:

  1. Update tdex-dashbord where GetMarketBalance is used in here and here
  2. Update tdex-analytics where GetMarketBalance is used in here
altafan commented 2 years ago

it seems to me that 2) is actually using GetMarketBalance from TradeService, not from OperatorService.

I think it's better to do this when detaching the wallet then, when we introduce operator/v2 protos.

altafan commented 1 year ago

done in v1.