search

tdex-network / tdex-daemon

Go implementation of the TDEX Beta Daemon
https://tdex.network
MIT License
11 stars 13 forks source link

TLS unset isCA indicator #648

Closed sekulicd closed 2 years ago

sekulicd commented 2 years ago

This unsets isCA certificate indicator.

Regarding: "We might want to explore also if it's possible to remove its expiration date. Currently, it is set to 1 year" -> I dont see any validation preventing this.

This closes #645

@tiero @altafan please review.

altafan commented 2 years ago

@sekulicd if it's not a problem, let's remove the expiration date from the cert then.

sekulicd commented 2 years ago

@sekulicd if it's not a problem, let's remove the expiration date from the cert then.

Sorry, I made a mistake, we cant remove it since if removed default time(0001-01-01T00:00:00Z) is set for both before/after and there is verification in here. So we cant remove expiration time, verified by testing as well.