tdex-network / tdex-daemon

Go implementation of the TDEX Beta Daemon
https://tdex.network
MIT License
11 stars 13 forks source link

[Feature Request] ListWebhook - Add an ActionType to retrieve all hooks #666

Closed Janaka-Steph closed 1 year ago

Janaka-Steph commented 1 year ago

ACTION_TYPE_ALL_ACTIONS doesn't return all types. It only returns hooks set with action Any. It would be nice to be able to retrieve hooks of all possible types with a single request.

Also renaming ACTION_TYPE_ALL_ACTIONS to ACTION_TYPE_ANY_ACTIONS

altafan commented 1 year ago

I don't think it's necessary to add a new action type to retrieve all hooks, and it doesn't make really sense either IMO because we want to list all webhooks regardless their action.

Rather, we can either add a new RPC ListAllWebhooks or add a new boolean field all to the ListWebhookRequest message.

altafan commented 1 year ago

cc @tiero

tiero commented 1 year ago

add a new RPC ListAllWebhooks

this seems the way to go