Closed altafan closed 1 year ago
Modified onLock
function in service.go
Changed the stopMacaroonSvc
variable to false
instead of true
.
Updated onLock
function in service_one_port.go
s.withMacaroons()
is true.macaroonSvc.Close()
function call.stopMacaroonSvc
variable to false
instead of true
.s.start(withWalletOnly)
function call at the end.These changes were made to streamline the onLock
function in both files, removing unnecessary checks and calls, and having a more consistent behavior across the codebase.
ACK
Before this there were problems with the macaroon service after changing the main password and unlocking the daemon.
The reason for this bug was due to the fact that the macaroon service was stopped when locking the daemon, making impossible to update its password and therefore unlocking with the new one.
With this, the macaroon service is not stopped anymore when locking the wallet.
Please @sekulicd review this.