Closed altafan closed 1 year ago
Introduction of New Flag for Market Command
The market
command has been enhanced with a new flag --balanced
to provide more sophisticated control. This modification primarily affects the code in cmd/tdex/market.go
.
Expansion of Time Frame Flags for Market Report
The marketReport
command now has additional flags to filter the market's data based on various time scopes. You can now request reports for the last hour, day, month, three months, year, the year to date, or all time. This feature should allow for more detailed and adaptable market analysis.
Improvement of Data Validation in Various Functions
Several functions have been enhanced to correctly handle and validate the new time frame parameters introduced by the new flags. This includes the marketUpdateStrategyAction
, marketReportAction
, GetMarketReport
functions, and the getMarketReport
function in the gRPC's operator.
Addition of Helper Functions at Core Application Level
Two new helper functions: getDefaultTimeFrameForRange
and splitTimeRange
have been added. These assist with handling time frame related data.
Update of gRPC's Functionality to Handle New Time Frame Parameter Updates made in the gRPC layer to handle the newly introduced time frame parameter. This ensures its functioning remains consistent with the other applications.
Minor Environment Configuration Update
For the Docker compose file, the TDEX_NETWORK
environment variable is removed from the tdexd
service.
Have you validated these changes do not breaks the v2 of the dashaboard?
These changes do not affect the APIs, rather, they affect only the tdex-cli client, beside adding a default timeframe for market report at app level. The last change might turn out useful for any client in general, but it's still allowed to set a custom frame for the given timerange.
This contains changes for fixing the execution of the e2e on CI.
This also makes changes to the flags defined for
market report
andmarket strategy
commands.Before this, the operator should have specified the time range for
market report
with numeric values, while now more user-friendly flags are specified like--last-hour
,--last-day
, etc. If not specified within the API request, the daemon now makes use of a default time frame that depends on the length of the time range instead of using always1h
which is ok only for time ranges in the order of few days.This also adds a new flag
--balanced
to themarket strategy
command so that the operator must specify which strategy he wants for the current market. Before this, instead, only the--pluggbale
flag was defined.This also contains fixes to typos and polishes the docker-compose.yml file.