search

tdf / libcmis

C/C++ CMIS client library
GNU General Public License v2.0
21 stars 20 forks source link

Properly encode OAuth2 credentials #25

Closed stbergmann closed 5 years ago

stbergmann commented 5 years ago

Originally created as https://gerrit.libreoffice.org/#/c/59986/ "Properly encode OAuth2 credentials". I was not sure which C++ version to target, so kept it pretty basic.

stbergmann commented 5 years ago

[resurrecting the accidentally broken original https://github.com/tdf/libcmis/pull/20 "Properly encode OAuth2 credentials"]

dtardon commented 5 years ago

Is there any reason that addXWwwFormUrlencoded is a void function? It could just return the encoded value, could it not? And I don't like the name much either... Perhaps something easier to read, like escapeForm or escapeUrlForm (to match libcmis::escape)? Also, please use the same formatting style as the surrounding code.

dtardon commented 5 years ago

Thanks! Btw, the usual way to incorporate changes is to amend the existing commit(s) and force push.

stbergmann commented 5 years ago

Ah, sorry. Wasn't aware what the preferred github workflow is for that.