search

tdhock / mlr3resampling

Resampling algorithms for mlr3 framework in R
3 stars 1 forks source link

sizes support for same other CV #10

Closed tdhock closed 7 months ago

tdhock commented 8 months ago

Closes #9

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 96.72131% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.35%. Comparing base (6024174) to head (bd331c7).

Files Patch % Lines
R/ResamplingSameOtherSizesCV.R 96.72% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10 +/- ## ========================================== + Coverage 83.56% 88.35% +4.79% ========================================== Files 4 5 +1 Lines 213 335 +122 ========================================== + Hits 178 296 +118 - Misses 35 39 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tdhock commented 8 months ago

TODO n.train.atoms should be integer

score.atomic
      test.group train.groups atoms test.fold  seed n.train.atoms iteration
          <char>       <char> <num>     <int> <int>         <num>     <int>
   1:       test          all 54000         1     1       2250.00         1
   2:       test          all 54000         1     1       4500.00         2
   3:       test          all 54000         1     1       9000.00         3
   4:       test          all 54000         1     1      45000.00         4
   5:       test          all 54000         1     1      54000.00         5
  ---                                                                      
3565:        395         same   405        10     2        202.50      1436
3566:        395         same   405        10     2        405.00      1437
3567:        395         same   405        10     3        101.25      1438
3568:        395         same   405        10     3        202.50      1439
3569:        395         same   405        10     3        405.00      1440
tdhock commented 7 months ago

when there are more than 2 groups, there are too many sizes, which means a quadratic explosion: image there should only be 6 as below image