SCC sound is not accurate

tdlabac / MSX1_MiSTer

GNU General Public License v2.0

21 stars 4 forks source link

SCC sound is not accurate #14

Closed GuerreroNinja closed 1 year ago

GuerreroNinja commented 1 year ago

SCC sound does not match original SCC. You can test it by loading Salamander or Nemesis 2 in OCM core (MSX official core) and then loading them in the MSX1 core. The differences are quite noticeable.

tdlabac commented 1 year ago

Please try this edition. I found two bugs causing an error in SCC waveform playback. https://github.com/tdlabac/MSX1_MiSTer/blob/Slots/releases/MSX1_20221127_slots.rbf

GuerreroNinja commented 1 year ago

Thank you! Checking it right now...

GuerreroNinja commented 1 year ago

Ok, tested some titles and now they sound right, OK to my ears, but I have to compare to real hardware (will do tonight if I can get some spare time). BIG improvement, thank you!!

EDIT: Tested Salamander and it sounds PERFECT to me.

tdlabac commented 1 year ago

Fix in release 20221127