tdmalone / slackemon

Inspired by Pokémon Go, now you can catch and battle Pokémon with your teammates on Slack!
GNU General Public License v3.0
10 stars 3 forks source link

File/folder (and some function) structure needs slight redesigning #26

Closed tdmalone closed 7 years ago

tdmalone commented 7 years ago

Slackémon was originally part of another framework but since moving out has both retained the original structure of that framework and added additional integrations such as CI. Configuration for additional integrations pollutes the root folder, especially when there's some source code mixed in there too. In addition, from the original framework, some of these files do not much else but call counterparts in the slackemon/ folder... which in turn end up calling functions in _functions/pokemon, some of which use functions directly in the _functions folder.

Some of the functions are also prefixed pokedex_ rather than slackemon_, which reflect that that they were originally written for a Pokédex feature part of the same framework Slackémon came from.

Whew! So basically, the structure needs rethinking so it's clear and less confusing. At the same time, we should clear the root folder of any source code, and try to put some of the directly run code into functions where they can be properly tested.

tdmalone commented 7 years ago

This restructure is now in progress on https://github.com/tdmalone/slackemon/tree/tim

tdmalone commented 7 years ago

In line with #32 this restructure has now moved to https://github.com/tdmalone/slackemon/tree/file-restructure-%2326

tdmalone commented 7 years ago