search

tdmalone / slackemon

Inspired by Pokémon Go, now you can catch and battle Pokémon with your teammates on Slack!
GNU General Public License v3.0
10 stars 3 forks source link

Initial Compose support #29

Closed Naramsim closed 7 years ago

Naramsim commented 7 years ago

Hi, in this PR there is only PostgreSQL alpine.

We will need further work to add PHP and httpd. For now, let's check if our base image can connect with PostgreSQL.

The connection string a user should use is:

postgres://slackemon:slackemon@slackemon_db:5432/slackemon

Right now user, password, host, and database have quite the same names, should we differentiate them a little bit?

Oh, to deploy the containers: docker-compose up, to remove them: docker-compose down. To start detached add -d switch

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.02%) to 3.685% when pulling e9fe189473da1600e78a53f8fc4f8a523d15ee15 on Naramsim:compose into 6e2d29944d5cebcb089b3694d21aab4dbc833b3d on tdmalone:master.

tdmalone commented 7 years ago

Thanks for this @Naramsim! Thanks for fixing some of the things Codacy picked up too =]

I will test and review as soon as I can.

tdmalone commented 7 years ago

I won't test this just yet given our chat on Gitter - will wait until you have looked at php + apache, but let me know if you have any more Qs that I can help with.

Right now user, password, host, and database have quite the same names, should we differentiate them a little bit?

Not a massive issue but yeah, probably best to differentiate - if nothing else it helps people who are unfamiliar understand what's what. Maybe even just something like postgres://slackemon_user:slackemon_pass@slackemon_postgres:5432/slackemon_db? I dunno, that seems a bit weird. Is there a convention? user:pass@postgres/slackemon might even be shorter but isn't as clear.

Whatever we end up with can also be set as the default in .env.example (Heroku won't read from here, as we will just leave it out of app.json, and config.php already has a fallback to the constant Heroku provides by default).

Naramsim commented 7 years ago

OK, perfect 👍