search

tdmalone / slackemon

Inspired by Pokémon Go, now you can catch and battle Pokémon with your teammates on Slack!
GNU General Public License v3.0
10 stars 3 forks source link

Docker best practices #30

Closed Naramsim closed 7 years ago

Naramsim commented 7 years ago

Hi, better to merge after #29

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 3.704% when pulling 678dce3c5a936f31aaacf3c00b4792a1f0770880 on Naramsim:docker-best-practices into 6e2d29944d5cebcb089b3694d21aab4dbc833b3d on tdmalone:master.

tdmalone commented 7 years ago

@juz501 As I understand it the Dockerfile needs something to set it up with, and it's really just to bootstrap the environment. The user could change it if they wish. It's also only intended for local set up; the port should never be accessible to the public.

juz501 commented 7 years ago

Maybe we can do something like https://www.google.com.au/amp/s/davidwalsh.name/docker-compose-override/amp

tdmalone commented 7 years ago

Oh.. interesting. What do you think @Naramsim? From a comment on that article it looks like Docker Composer will also natively support .env files so that might be cleaner given we're already using it. However.... it does add another configuration step for the user. I'm not sure this is any different to eg. MySQL shipping with a default root password?

Naramsim commented 7 years ago

@tdmalone @juz501 I will look into it.