search

tdmalone / slackemon

Inspired by Pokémon Go, now you can catch and battle Pokémon with your teammates on Slack!
GNU General Public License v3.0
10 stars 3 forks source link

Pokemon emojis not loaded on playslackemon.slack.com #36

Open juz501 opened 7 years ago

juz501 commented 7 years ago

Should load the emojis

juz501 commented 7 years ago

for the pokemon btw.. the elemental ones work

tdmalone commented 7 years ago

Yeah I know, I haven't got to that yet :P

I've made you an admin of the Slack team if you want to have a crack at it, otherwise I will get to it later on.

We need to add the steps as we go to the README here (point 9 under Setup).

Here are the tools I used last time (I think - there's a few out there that do it): https://github.com/Templarian/slack-emoji-pokemon https://github.com/lambtron/emojipacks

tdmalone commented 7 years ago

Also missing:

:party_parrot:
:fingers_crossed:

EDIT: These two are now done. Pokemon are not done yet.

tdmalone commented 7 years ago

I've started on the Pokemon emoji in https://github.com/tdmalone/slackemon/commit/5de12f6a95f60802a38a6e300cd73cba71f19de5. Most of that was automated based on an ls in the pokecss-media repo and some Sublime wrangling, but it needs some manual fixing for the files that have hyphens in them. ~I'm up to ~B~ ~H~ so far :P~ DONE

This should then work with https://github.com/lambtron/emojipacks but I'll test it with a small subset first to make sure the images are the right size for Slack (EDIT - it works).

If all works I will update the README here and also notify https://github.com/Templarian/slack-emoji-pokemon that I've put this together, as they only have Gen I and sort of Gen II there at the moment.

tdmalone commented 7 years ago

Most emoji are now uploaded to playslackemon.slack.com.

Some didn't work - I need to look into why; probably the filesizes or dimensions are too big to use some for emoji; we might need to source alternatives or otherwise edit them down.

EDIT - Yes, anything with a dimension over 128px will fail.

Pokemon I've caught in Slackemon that didn't work:

There may be more (probably is, especially Gen IV onwards).

This is all being tracked on the emoji branch.

tdmalone commented 7 years ago

All of the above updates are now in master as of v0.0.41.

Still needs above 128px images fixed.