search

tdmalone / working-plusplus

Like plusplus.chat, but one that actually works, because you can host it yourself 😉
MIT License
23 stars 41 forks source link

Added == #14

Open MattLParker opened 5 years ago

MattLParker commented 5 years ago

Added == and made it where bot can get points as well. @bot == will throw error in log but does work.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 105

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/operations.js 0 1 0.0%
src/messages.js 2 4 50.0%
src/events.js 2 7 28.57%
src/points.js 1 8 12.5%
<!-- Total: 6 21 28.57% -->
Totals Coverage Status
Change from base Build 89: -2.4%
Covered Lines: 260
Relevant Lines: 350
💛 - Coveralls
tdmalone commented 5 years ago

Thanks for this @MattLParker!

There's a few things I'd like to change before getting this into master, primarily fixing a bit of duplicate code and updating some inline documentation. I know you've already put a lot of effort into this; are you interested in some detailed feedback or would you prefer I make the changes and go from there?

MattLParker commented 5 years ago

Hey, We are using the code on a slack group already as is. I'm really just trying to dig into JS, So feel free to make changes and I will watch and learn :)

tdmalone commented 5 years ago

No probs! I'll aim to get to it this weekend :)

Thanks again for contributing the code back!

SkUrRiEr commented 5 years ago

Oh, and on tone, I'm happy with the messages for now, I'll work out better wording for us and change that separately.

SkUrRiEr commented 5 years ago

Oh, and you should update README.md as well.

MattLParker commented 5 years ago

Our main repo for our slack is https://github.com/winadminsdotorg/PointsBot I also just added a @user ## to random give or take a point. Follow us if your interested in pulling any features, I won't bother with PRs.

MattLParker commented 5 years ago

I think that covers those problems?

SkUrRiEr commented 5 years ago

Our main repo for our slack is https://github.com/winadminsdotorg/PointsBot I also just added a @user ## to random give or take a point. Follow us if your interested in pulling any features, I won't bother with PRs.

90% of the "problems" with this PR is the site-specific stuff. Implementing that properly is next on my list for development (once I get back to this project).

Please feel free to send us more PRs!