Open Alex-Vol-SV opened 4 years ago
tdmalone
commented
4 years ago Hi @Alex-Vol-SV,
Just wanted to drop in quickly to thank you very much for your PRs. I’m currently travelling for an extended period so I’m not going to have a chance to review these for at least the next couple of months, just didn’t want you to not hear anything at all for that long! I’ll let you know once I’ve been able to have a proper look.
Alex-Vol-SV
commented
4 years ago @tdmalone I may take a stab at fixing your .travis-postgres10.sh script that seems to fail to correctly upgrade postgresql 10 and caused the PR builds to fail as a result.
coveralls
commented
4 years ago | Totals | |
|---|---|
| Change from base Build 89: | 0.5% |
| Covered Lines: | 262 |
| Relevant Lines: | 337 |
Alex-Vol-SV
commented
4 years ago I was able to fix the issues with the new base images. It was simple once I realized the problem was that PG 10 is now properly supported.
I created 3 PR with each building on the previous one, this one combines the commits from the other two. Feel free to merge this and ignore the other two or just merge one at a time starting with the Travis fix first, then the SQL injection and finally this one.
If you prefer three separate PR for each issue I can break it up but until master has the Travis CI configuration fixes the other PR fail t build.
This combined PR adds the fix to allow multiple mentions in the same message to work for plus/minus actions. I do not find a good reason why other kinds of actions should be combined.
The handleSelfPlus code was merged into the handlePlusMinus code as it made the operation able to use with other plus/minus operations.
The usage did not change, all that happens is each ++/-- will be added as a line in a multiline message where before only the very first ++/-- would be considered.
See my other PR for some comments relating to the SQL injection fix.
This fixes issue #8