search

tdmalone / working-plusplus

Like plusplus.chat, but one that actually works, because you can host it yourself 😉
MIT License
23 stars 41 forks source link

Changed the preposition 'on' to 'at' during point change report. #6

Closed nichus closed 6 years ago

nichus commented 6 years ago

Just started using working-plusplus, and thought I could take a couple minutes to fix up something we noticed.

Perhaps I'm wrong, but I believe that the proper preposition for the PLUS/MINUS operation is 'at' rather than 'on'. This PR addresses that.

To be honest, I haven't tested this change, but given that it's just a string change, I don't believe that should be required.

tdmalone commented 6 years ago

Thanks for the PR @nichus and it's cool to hear you're enjoying working-plusplus!

To be honest... I think 'at' doesn't sound right here. Maybe 'has' could be an alternative word. If I was talking about a footy team, I wouldn't say 'they're at 10 points' (aka 'Tim is at 10 points'); I'd say 'they're on 10 points' (aka 'Tim is on 10 points') or 'they've got 10 points' (aka 'Tim has 10 points')... or perhaps even 'scored 10 points'. But 'at 10 points' doesn't sound quite right to me, or the one other person I just asked in my un-scientific study.

If 'on' doesn't sound right to you though, perhaps it is a localisation thing? (or localization, since I note you're in the US 😛). I'd be happy to take a PR to make the word configurable - or, even better, to make the whole string configurable, with placeholders for name, points, and if applicable, singular/plural versions of the word 'points'/whatever a user might chose to replace it.

As it is though I don't think I can accept this PR - at least without some further info explaining why/whether the grammar is incorrect (I'm finding it a hard thing to Google).

Note: Build failure was due to an error I made in master 😮 which I need to fix (just sending coverage data to coveralls). Passes otherwise.

nichus commented 6 years ago

Yep, I can certainly understand that it might be a localisation "issue". Us yanks really know how to abuse a language :smile: . For now, I think I'll just push my fork up to my heroku instance. If I get the time, and available focus, to engage in a more thorough PR, localization, enhanced string configurability, or whatnot, then I'll certainly submit that.

Thanks for considering the PR!

I looked at the build failures as well, but realized that it was something with coveralls, and decided it wasn't something I was going to fix today. :smile: Thanks for writing this up!