search

tdmorello / napari-geojson

BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

detecting rectangle (is_rectangle) #7

Open yunhal opened 1 year ago

yunhal commented 1 year ago

Can I request a working function of is_rectangle? One of my GEOJSON data has 4 points, which is currently classified as polygon and it leads napari to crash.

tdmorello commented 1 year ago

Yes, absolutely. Can you send me the geojson file or a geojson file with the shape that causes it to crash?

yunhal commented 1 year ago

I really appreciate your quick response!

I attached my geojson file here - please remove ".txt" ending before using it. Side note that this file seems to have some error in data (e.g., weirdness in bottom part of South Africa). However it should be enough for improving "is_rectangle" function.

Thanks again!

world.geojson.txt

tdmorello commented 1 year ago

Hi @yunhal , can you tell me which version of napari you are using?

yunhal commented 1 year ago

Hi Tim. Here is my napari environment information:

napari: 0.4.16 Platform: macOS-12.6-x86_64-i386-64bit System: MacOS 12.6 Python: 3.10.6 | packaged by conda-forge | (main, Aug 22 2022, 20:43:44) [Clang 13.0.1 ] Qt: 5.15.4 PyQt5: 5.15.7 NumPy: 1.23.3 SciPy: 1.9.1 Dask: 2022.9.2 VisPy: 0.10.0 OpenGL:

GL version: 2.1 ATI-4.8.101 MAX_TEXTURE_SIZE: 16384 Screens:

screen 1: resolution 1920x1080, scale 2.0 Plugins:

brainglobe-napari-io: 0.1.5 brainreg-napari: 0.0.5rc0 brainreg-segment: 0.2.16 console: 0.0.6 napari-animation: 0.0.5 napari-dataset: 0.1.dev81+g454e834 napari-geojson: 0.1.3 napari-svg: 0.1.6 ndtiffs: 0.1.2 scikit-image: 0.4.16