search

tdolby / python-iridium-modem

Iridium modem module for Python built on python-gsmmodem
GNU Lesser General Public License v3.0
5 stars 1 forks source link

Fix serial handling classes #2

Closed tdolby closed 4 years ago

tdolby commented 4 years ago

PythonThreeFourSerialWrapper was presumably needed some time ago, but should at the very least be renamed, and ideally deleted.

tdolby commented 4 years ago

Wrapping the binary SBD data in a class that can handle encode() and + seems to do the trick, and means PythonThreeFourSerialWrapper is no longer needed for binary data. It also appeared to reset the timeout, but that's fixable by overriding write() and changing the timeout if it's too low.